Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed first review round comments on Setup chapter #61

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

frankcorneliusmartin
Copy link
Contributor

@frankcorneliusmartin frankcorneliusmartin commented Aug 6, 2024

Processed most comments from #48

Copy link

github-actions bot commented Aug 6, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/vantage6/vantage6-workshop/compare/md-outputs..md-outputs-PR-61

The following changes were observed in the rendered markdown documents:

 md5sum.txt |   2 +-
 setup.md   | 104 ++++++++++++++++++++++++++++++++-----------------------------
 2 files changed, 56 insertions(+), 50 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-06 12:42:51 +0000

@frankcorneliusmartin frankcorneliusmartin linked an issue Aug 6, 2024 that may be closed by this pull request
10 tasks
@frankcorneliusmartin frankcorneliusmartin removed a link to an issue Aug 6, 2024
10 tasks
@frankcorneliusmartin frankcorneliusmartin mentioned this pull request Aug 6, 2024
10 tasks
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
@CunliangGeng CunliangGeng self-requested a review August 6, 2024 12:23
Copy link
Member

@CunliangGeng CunliangGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with two minor comments.

frankcorneliusmartin and others added 2 commits August 6, 2024 14:41
Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl>
Co-authored-by: Cunliang Geng <c.geng@esciencecenter.nl>
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
@CunliangGeng CunliangGeng merged commit c3cd0f4 into main Aug 6, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Auto-generated via {sandpaper}
Source  : c3cd0f4
Branch  : main
Author  : Cunliang Geng <c.geng@esciencecenter.nl>
Time    : 2024-08-06 13:02:42 +0000
Message : Merge pull request #61 from vantage6/process-comments-on-setup-chapter

Addressed first review round comments on Setup chapter
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
Auto-generated via {sandpaper}
Source  : 57adb54
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-08-06 13:03:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c3cd0f4
Branch  : main
Author  : Cunliang Geng <c.geng@esciencecenter.nl>
Time    : 2024-08-06 13:02:42 +0000
Message : Merge pull request #61 from vantage6/process-comments-on-setup-chapter

Addressed first review round comments on Setup chapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants